[PATCH 08/12] mesh: Make plink params configurable

Bob Copeland me at bobcopeland.com
Tue Nov 4 08:34:09 EST 2014


On Tue, Nov 04, 2014 at 02:36:49PM +0900, Masashi Honma wrote:
> This patch makes four MIBs for plink configurable.
> 
> You can configure dot11MeshMaxRetries, dot11MeshRetryTimeout,
> dot11MeshConfirmTimeout and dot11MeshHoldingTimeout by config file like this
>         mesh_plink_params=1 2 3 4
> or wpa_cli command like this.
>         set_network 0 mesh_plink_params 1 2 3 4
> 
> And this patch sets correct default value based on spec to the MIBs.

So I like that this stuff is configurable - great!

But I think we should specify them separately, and use the std names in the
config file.  E.g. user might not want to customize the retries but
wants to set one of the timeouts, in this patch they have to set them
all.

-- 
Bob Copeland %% www.bobcopeland.com


More information about the HostAP mailing list