[PATCH] Add epoll option for better performance

Jouni Malinen j at w1.fi
Tue May 13 10:14:08 EDT 2014


On Tue, May 13, 2014 at 09:35:48AM +0900, Masashi Honma wrote:
> > On its own, this does not seem to be changing anything, so I'm not going to
> > apply it without some real justification showing how this is going to be
> > used with the following changes (epoll).
> 
> This is the following patch.

Hmm.. This seems to be changing the design completely from where the
changes were previously going.. While there is nothing particularly
wrong with this approach, it is a bit difficult to understand why there
was such a change in the design rather than a minor change to fix the
previous version to not end up commenting out both options in a way that
resulted in a busy loop.

I guess you don't care too much about the exact mechanism, so for now,
we might as well go with this addition of CONFIG_ELOOP_EPOLL=y and leave
the cleanup of CONFIG_ELOOP for future, if anyone cares enough about it.
Could you please confirm that this combination of the last two patches
have been tested to work with epoll?

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list