[PATCH] hostapd: Advertise OBSS scan params based on driver capability

Rajkumar Manoharan rmanohar at qti.qualcomm.com
Tue May 6 22:51:51 EDT 2014


On Tue, May 06, 2014 at 01:05:54PM -0700, Paul Stewart wrote:
>    On Tue, May 6, 2014 at 11:52 AM, Rajkumar Manoharan
>    <rmanohar at qti.qualcomm.com> wrote:
> 
>      On Tue, May 06, 2014 at 09:49:57AM -0700, Paul Stewart wrote:
>      >    On Tue, May 6, 2014 at 9:32 AM, Rajkumar Manoharan
>      >    <rmanohar at qti.qualcomm.com> wrote:
>      >
>      >      On Tue, May 06, 2014 at 08:02:49AM -0700, Paul Stewart wrote:
>      >      >      diff --git a/src/ap/ieee802_11_ht.c
>      b/src/ap/ieee802_11_ht.c
>      >      >      index c0a7cd4..7020858 100644
>      >      >      --- a/src/ap/ieee802_11_ht.c
>      >      >      +++ b/src/ap/ieee802_11_ht.c
>      >      >      @@ -46,7 +46,8 @@ u8 * hostapd_eid_ht_capabilities(struct
>      >      hostapd_data
>      >      >      *hapd, u8 *eid)
>      >      >
>      >      >              pos += sizeof(*cap);
>      >      >
>      >      >      -       if (hapd->iconf->obss_interval) {
>      >      >      +       if (hapd->iconf->obss_interval &&
>      >      >      +           (hapd->iface->drv_flags &
>      >      WPA_DRIVER_FLAGS_HT_2040_COEX)) {
>      >
>      >    This is an example of the concern I was bringing up.  This
>      conditional
>      >    will trigger only if the driver flags contain
>      >     WPA_DRIVER_FLAGS_HT_2040_COEX.  I'd like to be able to include
>      this IE
>      >    for testing purposes even if the driver doesn't support this flag.
>      Hmm... I am not sure whether it is correct to set default based on
>      device capability. For WFA testing, there is no configuration steps for
>      OBSS
>      scan interval and the expectation is that AP should advertise OBSS scan
>      param by default.
> 
>    I don't care so much what behavior is set by default.  I would just like
>    the ability to set it as necessary.  I don't mind that hostapd's default
>    behavior might be tuned to perform to WFA's specifications.  I just want
>    to be able to do my tests as well.  For example, there could be a special
>    value that obss_interval defaults to, which implies "defined by hardware
>    capability".  The config file can either disable OBSS by setting the value
>    explicitly to zero, or force OBSS by setting it to a non-zero value.
Sounds clear. Let me drop this change. Thanks for the review.

-Rajkumar


More information about the HostAP mailing list