[PATCH 2/3] hostapd: Fix explicit VHT channel switching

Peer, Ilan ilan.peer at intel.com
Wed Mar 19 07:11:16 EDT 2014


> -----Original Message-----
> From: Michal Kazior [mailto:michal.kazior at tieto.com]
> Sent: Wednesday, March 19, 2014 10:27
> To: Peer, Ilan
> Cc: j at w1.fi; hostap at lists.shmoo.com
> Subject: Re: [PATCH 2/3] hostapd: Fix explicit VHT channel switching
> 
> On 19 March 2014 09:20, Peer, Ilan <ilan.peer at intel.com> wrote:
> > Hi Michal,
> >
> >> -----Original Message-----
> >> From: hostap-bounces at lists.shmoo.com [mailto:hostap-
> >> bounces at lists.shmoo.com] On Behalf Of Michal Kazior
> >> Sent: Tuesday, March 18, 2014 14:38
> >> To: j at w1.fi
> >> Cc: hostap at lists.shmoo.com
> >> Subject: [PATCH 2/3] hostapd: Fix explicit VHT channel switching
> >>
> >> diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c index
> >> 439bf66..9ed7601 100644
> >> --- a/src/ap/drv_callbacks.c
> >> +++ b/src/ap/drv_callbacks.c
> >> @@ -480,6 +480,8 @@ void hostapd_event_ch_switch(struct
> hostapd_data
> >> *hapd, int freq, int ht,
> >>
> >>       if (hapd->iface->csa_in_progress &&
> >>           freq == hapd->iface->cs_freq_params.freq) {
> >> +             hapd->iconf->ieee80211ac = hapd->iface-
> >> >cs_freq_params.vht_enabled;
> >> +
> >
> > Same as in the previous patch I think. hapd->iface-
> >cs_freq_params.vht_enabled is set based on the ieee80211ac, so I do not
> think that there is a need to update it here.
> 
> With chan_switch you can have vht_enabled true/false. Without this line you
> get invalid IEs after CSA in some cases.

Agree that the current situation is not good, getting to situations that we report to support HT/VHT although this is not true. I just think that changing ieee80211ac is not the right path. As discussed previously, I think that it would be more appropriate to differentiate between the enabled capabilities and the actual current state, and use the current state (both HT/VHT) in the flows.

Ilan.



More information about the HostAP mailing list