[PATCH] TDLS: Add get_capability tdls command

Dmitry Shmidt dimitrysh at google.com
Thu Mar 13 18:14:25 EDT 2014


On Thu, Mar 13, 2014 at 2:53 PM, Jouni Malinen <j at w1.fi> wrote:
> On Thu, Mar 13, 2014 at 02:03:28PM -0700, Dmitry Shmidt wrote:
>> Command returns info in format:
>>   TDLS supported = YES / NO
>>   Driver uses INTERNAL / EXTERNAL link setup
>
> This looks pretty verbose and harder than necessary format to parse..
> Why not simply return UNSUPPORTED/INTERNAL/EXTERNAL? In addition, this
> information is available from wpa_s->drv_flags
> (WPA_DRIVER_FLAGS_TDLS_SUPPORT and WPA_DRIVER_FLAGS_TDLS_EXTERNAL_SETUP
> bits), so there is no need to add the new wpa_tdls_is_supported()
> wrapper function (the core wpa_supplicant code sets that
> sm->tdls_supported based on drv_flags anyway).

Changed. Thanks!

>
> --
> Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list