Fwd: Re: Re: [PATCH] Use P2P_IE_VENDOR_TYPE instead of combination of OUI_WFA and P2P_OUI_TYPE

Jouni Malinen j at w1.fi
Wed Mar 5 17:47:59 EST 2014


On Mon, Mar 03, 2014 at 03:14:04AM +0000, Rahul Jain wrote:
> Subject: [PATCH] Use P2P_IE_VENDOR_TYPE instead of combination of OUI_WFA and
>   P2P_OUI_TYPE

Thanks, applied. Though, with this bounds checking fixed:

> diff --git a/src/p2p/p2p.c b/src/p2p/p2p.c
> @@ -1662,18 +1662,15 @@ static void p2p_rx_action_public(struct p2p_data *p2p, const u8 *da,
>  		len--;
>  		if (len < 3)
>  			return;
> -		if (WPA_GET_BE24(data) != OUI_WFA)
> +		if (WPA_GET_BE32(data) != P2P_IE_VENDOR_TYPE)


That len < 3 needs to be len < 4 with the new design.

>  		if (len < 1)
>  			return;

While this one can be removed.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list