[PATCH 0/7 v3] wpa_supplicant P2P DBus API improvements

Tomasz Bursztyka tomasz.bursztyka at linux.intel.com
Wed Jun 25 04:30:40 EDT 2014


Hi Jouni,

> It's on the list.. That said, since I don't use D-Bus much myself, I
> normally hope that others using D-Bus take a closer look at this type of
> changes.

Something tells me no-one has been using P2P DBus API yet. Besides this 
patch,
I fixed already quite some issues (already upstream). Without all those 
it's basically
impossible to get a consistent P2P experience through this API. So 
people would have
complained already before I guess.

Just found another one btw: GroupFinished is raised from the interface 
to which the
finished group belongs to, but it does no provide the group object path 
in the signal
properties (as GroupStarted does properly), so it's painful in client 
side to know which
group has been removed, in a multi-group context I think it can generate 
issues.
I'll send a patch for it.

> As a friendly hint, it would also make it easier and likely faster for
> me to accept D-Bus changes if someone were to contribute hwsim test
> cases (see tests/hwsim/README) to exercise the D-Bus interface..:-)

Sure, why not.
I noticed some python script there implementing a test for a signal 
which is not implemented
for instance (P2PStateChanged). So there is probably both sides to work 
on yhere.
(Actually I don't know what's the point of this signal)

Tomasz


More information about the HostAP mailing list