[PATCH] driver_nl80211: treat RSSI as part of each sched scan matchset

Jouni Malinen j at w1.fi
Thu Jan 30 06:52:32 EST 2014


On Fri, Jan 24, 2014 at 01:32:27PM +0100, Johannes Berg wrote:
> While at it, remove a useless cast and fix indentation.

> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> @@ -4873,7 +4873,7 @@ static int wpa_driver_nl80211_sched_scan(void *priv,
>  	NLA_PUT_U32(msg, NL80211_ATTR_SCHED_SCAN_INTERVAL, interval);
>  
>  	if ((drv->num_filter_ssids &&
> -	    (int) drv->num_filter_ssids <= drv->capa.max_match_sets) ||
> +	     drv->num_filter_ssids <= drv->capa.max_match_sets) ||
>  	    params->filter_rssi) {

That's not a useless cast:

../src/drivers/driver_nl80211.c: In function ‘wpa_driver_nl80211_sched_scan’:
../src/drivers/driver_nl80211.c:4979:29: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

I'm dropping this part. If you want to get this cleaned up, I could
consider a patch that does this and makes max_match_sets unsigned.. :)

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list