[PATCH 1/2] P2P: Add missing direct global ctrl_iface commands for P2P

Jouni Malinen j at w1.fi
Fri Jan 17 05:37:07 EST 2014


On Wed, Jan 15, 2014 at 10:27:19AM -0800, Dmitry Shmidt wrote:
> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -6345,6 +6345,8 @@ static char * wpas_global_ctrl_iface_redir_p2p(struct wpa_global *global,
>  #ifdef CONFIG_P2P
>  	static const char * cmd[] = {
> +		"LIST_NETWORKS",
> +		"SAVE_CONFIG",

>  	static const char * prefix[] = {
> +#ifdef ANDROID
> +		"DRIVER ",
> +#endif
> +		"GET_NETWORK ",
> +		"REMOVE_NETWORK ",
> +		"SET ",

Thanks, applied. Though, I want to make sure it is understood that these
commands are not explicitly for P2P uses and they may even be used for
per-interface operations. Doing such operations through the global
control interface without the IFNAME= prefix has undefined behavior and
that behavior may change. As such, I would not recommend using these for
anything else than operations that are clearly in global context (e.g.,
for P2P management purposes). I added that note to the commit message as
well.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list