[PATCH 1/3] pno: Change sched_scan_stopped event to handle pending PNO properly

Peer, Ilan ilan.peer at intel.com
Tue Feb 25 09:11:24 EST 2014


> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Tuesday, February 25, 2014 15:52
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com
> Subject: Re: [PATCH 1/3] pno: Change sched_scan_stopped event to handle
> pending PNO properly
> 
> On Thu, Feb 13, 2014 at 11:23:59AM +0200, Ilan Peer wrote:
> > From: Alexander Bondar <alexander.bondar at intel.com>
> >
> > 1. Move pno_start and pno_stop to scan.c as more relevant location.
> Rename
> >    them to wpa_supplicant_start_pno/stop_pno.
> > 2. Change wpa_supplicant_stop_pno so that nothing will be done if PNO is
> >    not in progress.
> > 3. When a sched_scan_stopped event is received and there is a pending
> PNO,
> >    it uses regular scheduled scan parameters instead of PNO specific
> >    parameters. Change it by calling wpa_supplicant_start_pno.
> 
> Could you please split this type of changes into two or more commits? I want
> to be able to see the real changes separately both now when reviewing this
> and when looking at commits later. Moving functions in the same commit
> while changing them makes this unnecessarily painful. In addition, I'm
> moving more and more towards using "wpas_" prefix instead of
> "wpa_supplicant_" to avoid long function names.
> 


Np. You want this to for future patches or this one as well?

Thanks,

Ilan.


More information about the HostAP mailing list