[PATCH 1/2] hostapd: make it possible to remove addresses from maclists

Emanuel Taube emanuel.taube at gmail.com
Wed Feb 19 10:30:10 EST 2014


Thank you, for the feedback.
I've just sent in v2 with your corrections built in.


In addition, it looks like this loop would skip checking the entry
> following the one that got removed. Not that there is an expectation for
> there to be multiple entries for the same MAC address, but since that
> loop did not break out on the first match, it looks like it is trying to
> handle that case as well.
>

Indeed it tries to handle that case as well, cause nothing prevents the
other
side to send in the same mac address twice for whatever reason. And I
think changing the mac address list at runtime could higher the possibility
for that to happen.

Regards,
Emanuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20140219/34c703c9/attachment.htm>


More information about the HostAP mailing list