[PATCH 1/1] P2P Client should not issue p2p_find

Eduardo Abinader eduardo.abinader at openbossa.org
Fri Feb 14 06:03:33 EST 2014


On Fri, Feb 14, 2014 at 5:35 AM, Jouni Malinen <j at w1.fi> wrote:

> On Thu, Feb 13, 2014 at 06:17:16PM -0400, Eduardo Abinader wrote:
> > If you connect wpa_cli to a p2p interface, p2p_find fails.
>
> Which driver are you using? Which operation fails?
>
>
It fails with my patch, considering the info below.



> > Page 96 states PB can be trasmitted by any P2P Device (not P2P client or
> > GO), thus this patch still allows P2P device (ifname==wlan*) to p2p_find,
> > as p2p_group_interface==NOT_P2P_GROUP_INTERFACE.
> > This patch only disallows a P2P Client (not a P2P device),
> > ifname==p2p-wlan* to p2p_find.
>
> p2p_find is always performed in P2P Device role. Whether it is issued on
> a control interface for another interface should not really matter much
> and it could be more convenient to just route the request to the correct
> instance within wpa_supplicant instead of rejecting it. I'm not sure
> whether there could be external programs that end up using a random
> control interface by not specifying any, so there is some risk of
> regressions with this type of changes. The new global control interface
> design avoids this, but similar redirection of the control interface
> command could be used here as well.
>
>
I was just thinking about a ConnMan-like listing p2p interfaces and getting
them to use via wpa_s dbus interfaces. This patch would prevent such
non-standard procedures.



> --
> Jouni Malinen                                           PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20140214/14839bbe/attachment.htm>


More information about the HostAP mailing list