[PATCH v2 08/10] mesh: Add virtual interface on booting

Jouni Malinen j at w1.fi
Wed Dec 24 13:04:48 EST 2014


On Tue, Dec 16, 2014 at 12:05:52PM +0900, Masashi Honma wrote:
> On 2014年12月15日 05:43, Jouni Malinen wrote:
> >Could you please clarify why this functionality needs to be enabled from
> >a command line? Didn't the MESH_INTERFACE_ADD command added support for
> >adding a new mesh interface? Does this new command line argument add
> >some significant extra functionality above that?
> 
> Purpose of this patch is creating mesh gate without any wpa_cli command.
> We can save mesh gate config to config file.
> But we can not specify creation of vif in config file.
> So I made this functionality.

This exact same "limitation" applies to P2P groups. Why should mesh gate
have an exception and need something new on the command line? That
sounds undesirable to me.. I.e., if you want this to behave just like
any other existing network block with disabled=0, there should not be
MESH_INTERFACE_ADD command in the first place. If on the other hand you
want this to be a special case, it sounds reasonable to expect
MESH_INTERFACE_ADD command to be used.. What is the issue with using
wpa_cli (or some other tool) to send a control interface command to
enable mesh gate operation?

I would like to better understand the high level use case for this. It
does not sound desirable to get new command line parameters needed for
all new types of connections and I don't see why mesh would be the
special case needing such a command while others would not.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list