[PATCH v2 08/10] mesh: Add virtual interface on booting

Jouni Malinen j at w1.fi
Sun Dec 14 15:43:41 EST 2014


On Sat, Nov 15, 2014 at 10:35:30AM +0900, Masashi Honma wrote:
> This functionality is used to create mesh gate.

Could you please clarify why this functionality needs to be enabled from
a command line? Didn't the MESH_INTERFACE_ADD command added support for
adding a new mesh interface? Does this new command line argument add
some significant extra functionality above that?

> diff --git a/wpa_supplicant/main.c b/wpa_supplicant/main.c
> @@ -175,7 +175,7 @@ int main(int argc, char *argv[])
>  		c = getopt(argc, argv,
> -			   "b:Bc:C:D:de:f:g:G:hi:I:KLm:No:O:p:P:qsTtuvW");
> +			   "b:Bc:C:D:de:f:g:G:hi:I:KLmn:No:O:p:P:qsTtuvW");

usage() needs to be updated to describe the new command line argument.
Similarly, wpa_supplicant/README and
wpa_supplicant/doc/docbook/wpa_supplicant.sgml should be updated
whenever adding new command line arguments.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list