[PATCH v2] hwsim tests: reduce duplication in startup code

Jouni Malinen j at w1.fi
Wed Oct 30 14:18:32 EDT 2013


On Wed, Oct 30, 2013 at 05:56:14PM +0100, Johannes Berg wrote:
> Instead of hard-coding four different cases, use variables
> (and printf) to reduce the duplication.

Thanks, applied.

> +    VALGRIND_WPAS="valgrind --log-file=$LOGDIR/$DATE-valgrind-wlan%d"
> +    VALGRIND_HAPD="valgrind --log-file=$LOGDIR/$DATE-valgrind-hostapd"
> +    # why chmod?
> +    chmod a+rx $WPAS
> +    chmod a+rx $HAPD

Because of valgrind under buildbot.. See commit
d011246f792ac2caebb679ca7ec34408fb2c3eab. I removed that comment.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list