[PATCH 1/1] STA: Request new scan only for the original interface

Jouni Malinen j at w1.fi
Tue Oct 22 09:03:27 EDT 2013

On Thu, Oct 17, 2013 at 04:11:04PM +0530, Jithu Jance wrote:
> Request new scan only for the interface for which the original
> scan request & results has come. Otherwise while sharing scan
> results along with P2P interfaces, the new scan will
> be requested on P2P interfaces.

> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> @@ -1275,7 +1275,7 @@ static int _wpa_supplicant_event_scan_results(struct wpa_supplicant *wpa_s,
> -	return wpas_select_network_from_last_scan(wpa_s, 1);
> +	return wpas_select_network_from_last_scan(wpa_s, own_request);

This would change the new_scan argument for
wpas_select_network_from_last_scan(). However, that argument is not
indicating whether a new scan is requested, but reporting whether the
scan results were from a new scan. As such, this change does not seem to
match the commit log. If the issue described in the commit log is indeed
a valid issue, the fix for it must be something completely different..
Maybe an additional "int own_request" argument for
wpas_select_network_from_last_scan() and using that to determine whether
to start the scan request at the end of the selected == NULL && ssid ==
NULL case?

Jouni Malinen                                            PGP id EFC895FA

More information about the HostAP mailing list