[PATCH v2 1/3] hostapd: Add AP DFS support
janusz.dziedzic at tieto.com
Thu Oct 17 03:09:32 EDT 2013
On 16 October 2013 16:04, Jouni Malinen <j at w1.fi> wrote:
> On Mon, Oct 07, 2013 at 08:30:07AM +0200, Janusz Dziedzic wrote:
>> Add DFS structures/events handlers, CAC handling,
>> radar detection. By default after radar detected or
>> channel became unavailable random channel
>> will be choose.
>> This patches are based on the original work by Boris Presman and
>> Victor Goldenshtein.
> Adding these changes in hostapd.c and then removing, re-adding them in
> dfs.c, and removing and replacing them yet again in the same patch
> series looks a bit odd.. I understand that this is partly because of
> different authors being involved and original authors not submitting
> this updated version, but the commits in this format make this way too
> complex to review and find any issues in changes to functionality.
> In addition to that, there were large number of coding style issues that
> made this series pretty inconvenient. The patches are too large for that
> matter (e.g., with the 3/3 going beyond the limit of this mailing list
> size requirements). Renaming of functions make the changes look more
> complex than they really were.
> I split the changes into smaller commits to make this somewhat more
> manageable and also merged some of the add-move-and-move-again parts
> into a single commit so that the total number of changes goes down.
> This is still far from ideal, but I think we've wasted way too much time
> on these as-is, so it is probably better to just commit these and move
> on with fixes on top of a fixed baseline.
> Since I needed to do significant amount of cleanup, could you please
> confirm that the update set of commits are fine? The latest snapshot of
> the relevant patches is here: http://w1.fi/p/dfs2/
Yes, I confirm.
We will have more patches (fixes) there, but like you wrote best is
just commit these and apply small fixes next.
More information about the HostAP