[PATCH] wpa_supplicant: don't try to stop sched scan when initialization fails

[Peer, Ilan]

> -----Original Message-----
> From: Coelho, Luciano
> Sent: Tuesday, November 05, 2013 10:55
> To: Jouni Malinen
> Cc: Peer, Ilan; hostap at lists.shmoo.com; Spinadel, David
> Subject: Re: [PATCH] wpa_supplicant: don't try to stop sched scan when
> initialization fails
> 
> On Tue, 2013-11-05 at 10:45 +0200, Jouni Malinen wrote:
> > On Sun, Nov 03, 2013 at 03:27:59PM +0200, Ilan Peer wrote:
> > > From: Luciano Coelho <luciano.coelho at intel.com>
> > >
> > > If something goes wrong during initialization, we were trying to
> > > stop schedule scan (and thus read data from wpa_s->drv_priv), but
> > > the driver data doesn't exist, so we were segfaulting.  Fix this by
> > > not trying to stop sched scans if the private driver data doesn't exist.
> >
> > Wasn't this issue introduced by the earlier commit in this set
> > ("wpa_supplicant: fix 2 bugs in cancel sched scan")? Before that,
> > wpa_supplicant_cancel_sched_scan() exited immediately on
> > !wpa_s->scan_scanning and I'd assume that could not be set without the
> > driver having been initialized.. In other words, this commit should
> > really be merged to the other one.
> 
> I agree.  I wrote this patch on top of our internal tree, which already included
> the commit that broke this.  My patch should be squashed.
> 
> --
> Luca.

Sorry for this. I'll squash based on the decision on the other patch.

Regards,

Ilan