[PATCH] wpa_supplicant: prevent segmentation fault in p2p_group_match_dev_type.

Jouni Malinen j at w1.fi
Sun Mar 10 11:13:34 EDT 2013


On Thu, Mar 07, 2013 at 11:09:38AM +0200, David Spinadel wrote:
> Add nullity check in p2p_group_match_dev_type().

> diff --git a/src/p2p/p2p_group.c b/src/p2p/p2p_group.c
> @@ -706,6 +706,9 @@ int p2p_group_match_dev_type(struct p2p_group *group, struct wpabuf *wps)
> +	if (group == NULL)
> +		return 0;

In what case can this happen? p2p_group_match_dev_type() is called only
from handle_probe_req() and only if P2P is enabled in the interface. If
hapd->p2p_group == NULL in that case, there is something seriously wrong
elsewhere and this is just hiding the real issue.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list