[PATCH] wpa_supplicant: support VHT capability overrides

Ben Greear greearb at candelatech.com
Fri Mar 1 12:52:41 EST 2013


On 03/01/2013 08:45 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg at intel.com>
>
> Add support for VHT capability overrides to allow testing connections
> with a subset of the VHT capabilities that are actually supported by
> the device. The only thing that isn't currently supported (by mac80211
> and this code) is the RX/TX highest rate field.
>
> Signed-hostap: Johannes Berg <johannes.berg at intel.com>

> +#define OVERRIDE_MCS(i)							\
> +	if (ssid->vht_tx_mcs_nss_ ##i >= 0) {				\
> +		vhtcaps_mask->vht_supported_mcs_set.tx_map |=		\
> +			3 << 2 * (i - 1);				\
> +		vhtcaps->vht_supported_mcs_set.tx_map |=		\
> +			ssid->vht_tx_mcs_nss_ ##i << 2 * (i - 1);	\
> +	}								\
> +	if (ssid->vht_rx_mcs_nss_ ##i >= 0) {				\
> +		vhtcaps_mask->vht_supported_mcs_set.rx_map |=		\
> +			3 << 2 * (i - 1);				\
> +		vhtcaps->vht_supported_mcs_set.rx_map |=		\
> +			ssid->vht_rx_mcs_nss_ ##i << 2 * (i - 1);	\
> +	}

Maybe some comments on the code above?

> +
> +	OVERRIDE_MCS(1);
> +	OVERRIDE_MCS(2);

...

> +# vht_rx_mcs_nss_1/2/3/4/5/6/7/8: override the MCS set for RX NSS 1-8
> +# vht_tx_mcs_nss_1/2/3/4/5/6/7/8: override the MCS set for TX NSS 1-8
> +#  0: MCS 0-7
> +#  1: MCS 0-8
> +#  2: MCS 0-9
> +#  3: not supported

I'm confused by this.  The MCS overrides I put in for
HT basically allowed setting each bit in the available
MCS rates.  Can you offer a bit more explanation on what
these VHT MCS settings allow/do?

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



More information about the HostAP mailing list