[PATCH] nl80211: Increase verbosity for some auth failures.

Jouni Malinen j at w1.fi
Sun Jan 6 13:25:10 EST 2013


On Wed, Jan 02, 2013 at 10:21:34AM -0800, Ben Greear wrote:
> Just to make sure I understand properly:  The patch should use
> wpa_printf() instead, but even if I changed it as you suggested, you don't
> want to apply the change upstream?

wpa_msg() with MSG_INFO is not fine for an event that happens frequently
during normal operations (i.e., without any kind of real error
condition). I don't think I would add wpa_printf(MSG_INFO) for this
either for the same reason. So yes, using MSG_INFO for these would sound
excessive unless the real error cases can be somehow identified (e.g.,
check that errno is not that EALREADY or whatever the common non-error
case is).
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list