[PATCH] supplicant/interworking: Convert wpa_printf to wpa_msg.

Jouni Malinen j at w1.fi
Sat Aug 31 03:21:02 EDT 2013


On Thu, Aug 29, 2013 at 03:15:45PM -0700, greearb at candelatech.com wrote:
> Also adds a new message that helped me track down why things
> were not working as expected.

Please keep these changes separate.. It is much easier to review changes
when independent additions are not merged together with large number of
wpa_printf to wpa_msg/wpa_dbg changes.

> diff --git a/wpa_supplicant/interworking.c b/wpa_supplicant/interworking.c
> @@ -185,8 +185,8 @@ static int interworking_anqp_send_req(struct wpa_supplicant *wpa_s,
> -	wpa_printf(MSG_DEBUG, "Interworking: ANQP Query Request to " MACSTR,
> -		   MAC2STR(bss->bssid));
> +	wpa_msg(wpa_s, MSG_DEBUG, "Interworking: ANQP Query Request to " MACSTR,
> +		MAC2STR(bss->bssid));

"wpa_printf(MSG_DEBUG" should almost always be replaced with
"wpa_dbg(wpa_s, MSG_DEBUG" instead of "wpa_msg(wpa_s, MSG_DEBUG" to
allow CONFIG_NO_STDOUT_DEBUG to work properly, i.e., to allow debug
messages to be removed to save binary size without affecting control
interface messages of higher importance.


Taken into account that there is a lot of ongoing changes for
interworking.c in separate development branch, these changes would cause
a large number of conflicts. Since these are not critical changes to do
at this point in time, I'd prefer to postpone these until the ongoing
work in this file can be merged in into a public repository.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list