[PATCH] p2p_supplicant: probe reporting should be from listen interface

Johannes Berg johannes at sipsolutions.net
Thu Apr 18 15:41:48 EDT 2013


On Thu, 2013-04-18 at 21:39 +0200, Arend van Spriel wrote:
> On 04/18/2013 07:44 PM, Johannes Berg wrote:
> > On Fri, 2013-04-05 at 12:51 +0200, Arend van Spriel wrote:
> >
> >>> I think they should be reported on the P2P_DEVICE. I believe that's
> >>> actually the case for our driver anyway since it just reports the
> >>> frames, and mac80211 will sort them according to the virtual interface
> >>> address.
> >
> > I was looking at this code for another reason and noticed that the
> > reporting is done using the bss->nl_mgmt socket -- maybe it should be
> > another socket?
> 
> Still not very proficient pn wpa_s, but the action frames are done in 
> similar way.
> 
> nl80211_init_p2p_dev():
>          /* Register P2P Public Action frame on the device interface */
>          type = (WLAN_FC_TYPE_MGMT << 2) | (WLAN_FC_STYPE_ACTION << 4);
>          nl80211_register_frame(p2p_dev, bss->nl_mgmt, type,
>                                 (u8 *) "\x04\x09\x50\x6f\x9a\x09", 6);

Yeah, I'm not convinced that's right either :-)

Also your patch breaks operating with hwsim.

I'm looking into it ...

johannes



More information about the HostAP mailing list