[PATCH] p2p_supplicant: probe reporting should be from listen interface

Arend van Spriel arend at broadcom.com
Fri Apr 5 04:12:06 EDT 2013


On 04/04/2013 08:40 PM, Arend van Spriel wrote:
> On 04/04/13 16:23, Spinadel, David wrote:
>>> -----Original Message-----
>>> From: hostap-bounces at lists.shmoo.com [mailto:hostap-
>>> bounces at lists.shmoo.com] On Behalf Of Arend van Spriel
>>> Sent: Thursday, March 28, 2013 16:39
>>> To: David Spinadel
>>> Cc: Greg Goldman; hostap at lists.shmoo.com; Johannes Berg
>>> Subject: [PATCH] p2p_supplicant: probe reporting should be from listen
>>> interface
>>>
>>> P2P listen phase is used to listen for P2P probe request messages from
>>> peers. The probe reporting call should be done on the same interface
>>> as the
>>> remain_on_channel.
>>>
>>> Cc: Greg Goldman<ggoldman at broadcom.com>
>>> Cc: Jithu Jance<jithu at broadcom.com>
>>> Cc: Johannes Berg<johannes at sipsolutions.net>
>>> Signed-hostap: Arend van Spriel<arend at broadcom.com>
>>> ---
>>> Hi David,
>>>
>>> Found during testing that my device was not found, because we were not
>>> responding to P2P probe requests during the listen phase.
>>>
>>> This patch fixes it for my driver and it kind of makes sense to me
>>> that the
>>> probe request reporting should be done on the same interface as the on
>>> doing the LISTEN.
>>>
>>> Not sure whether the P2P device patches are already applied so
>>> sending this
>>> patch to you first.
>>>
>>
>> Hmmm.
>> Your logic seems to be perfect, but it works fine for me without your
>> fix, and stops to work with it. Didn't debug it yet, but maybe
>> something is wrong with mac80211?
>
> As I am working with a fullmac driver it does not involve mac80211. Are
> you using a mac80211 driver? Otherwise, we have to look for another
> culprit ;-)

Hi Johannes,

It seems we are having an interworking issue here. During the P2P LISTEN 
state, should probe requests be reported on the P2P_DEVICE interface or 
on the primary interface? The probe response from wpa_supplicant should 
be sent on the P2P_DEVICE interface for sure, right? We need a consensus 
here on what behaviour is required.

Regards,
Arend



More information about the HostAP mailing list