[PATCH 6/7] Adding autoscan module named exponential

Jouni Malinen j at w1.fi
Sun Jun 24 06:07:53 EDT 2012


On Thu, May 03, 2012 at 04:16:55PM +0300, Tomasz Bursztyka wrote:
> This module will compute the interval on a base exponential.
> Thus, params to this module are following this format: <base>:<limit>

>  wpa_supplicant/Makefile               |    6 ++
>  wpa_supplicant/autoscan.c             |    7 ++
>  wpa_supplicant/autoscan_exponential.c |  105 +++++++++++++++++++++++++++++++++

It would be nice to get this (and same for 'periodic') documented in
wpa_supplicant/wpa_supplicant.conf with a reasonable example value
included there. The patch 1/7 could have added the documented from
config.h into wpa_supplicant.conf, too, and then these 6/7 and 7/7 could
extend that description.

> diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
> @@ -1311,6 +1311,12 @@ CFLAGS += -DCONFIG_BGSCAN
> +ifdef CONFIG_AUTOSCAN_EXPONENTIAL
> +CFLAGS += -DCONFIG_AUTOSCAN_EXPONENTIAL
> +OBJS += autoscan_exponential.o
> +NEED_AUTOSCAN=y
> +endif

Do you think we will get many more (or much larger) autoscan modules in
the future? If no, do we really need to make this configurable at build
time? I guess the autoscan.c itself could have enough size to justify
the extra complexity. Anyway, the added build configuration parameters
should be added to wpa_supplicant/defconfig.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list