[PATCH] dbus: Making the peer's properties acessible separately

Angie Chinchilla angie.v.chinchilla at intel.com
Wed Feb 22 14:27:49 EST 2012


Hi Flavio,

On Fri, 2012-02-17 at 12:09 -0800, Flávio Ceolin wrote:
> 2012/2/17 Flávio Ceolin <flavio.ceolin at profusion.mobi>:
> > Hi Angie,
> >
> > On Wed, Feb 15, 2012 at 6:05 PM, Jouni Malinen <j at w1.fi> wrote:
> >> On Mon, Feb 13, 2012 at 04:34:18PM -0800, Reinette Chatre wrote:
> >>> When the patch came in I wrongly assumed that the types will remain as
> >>> before, just the interface changed ... Thanks to Jouni for catching
> >>> these. From what I can tell the vendor extensions property type is still
> >>> different from before. Could this not perhaps remain as bytes?
> >>
> >> The problem there was that the previous mechanism used a dictionary and
> >> that does not have these types defined as clearly in introspection
> >> information.. Otherwise it would have been trivial for me to enforce
> >> them to remain same - now I did my best, but I'm not very familiar with
> >> D-Bus..
> >>
> >> In other words, yes, please take a closer look at the types that are in
> >> hostap.git now and propose a patch to change them if anything needs
> >> modification.
> >
> > I'm on a holiday, but the patch is pretty close to be finished,
> > sorry for the late. This last week I was in a hurry.
> >
> > Regards,
> > Flavio Ceolin
> 
> Just one more question, do you want keep compatibility
> with the current P2PDevice properties interface ?

Thanks for working on this patch. What do you mean by compatibility with
the current P2PDevice properties interface? 

If you're asking about keeping the function that returns all p2p device
properties at once, no, that should go away with your patch (the GetAll
replaces this).

If you're asking about keeping the individual types of the different
properties the same, then yes, I would expect those to remain the same.

-Angie



More information about the HostAP mailing list