[PATCH] p2p: Fix DBus crash and return additional information for P2P group properties

Chinchilla, Angie V angie.v.chinchilla at intel.com
Fri Feb 3 20:05:52 EST 2012


> -----Original Message-----
> From: hostap-bounces at lists.shmoo.com [mailto:hostap-
> bounces at lists.shmoo.com] On Behalf Of Angie Chinchilla
> Sent: Friday, February 03, 2012 4:46 PM
> To: hostap at lists.shmoo.com
> Cc: Previte, ToddX A
> Subject: [PATCH] p2p: Fix DBus crash and return additional information
> for P2P group properties
> 
> From: Todd Previte <toddx.a.previte at intel.com>
> 
> When using DBus to get group properties, a segmentation fault is
> generated on P2P
> clients due to a NULL pointer for the ap_iface struct. The current
> implementation
> only returns vendor extensions when called on a P2P group owner.
> 
> The code now checks the P2P role which allows for role-specific
> information to be
> provided. This also fixes the crash issue by only looking for the
> correct structures
> based on the current P2P role.
> 
> Signed-hostap: Todd Previte <toddx.a.previte at intel.com>
> Signed-hostap: Angie Chinchilla <angie.v.chinchilla at intel.com>
> ---
>  wpa_supplicant/dbus/dbus_new_handlers_p2p.c |   80
> ++++++++++++++++++++++-----
>  1 files changed, 66 insertions(+), 14 deletions(-)

This patch doesn't currently follow the P2P DBus interface changes 
proposed by Flávio. If we do decide to change the interface we'll 
write a second follow up patch that brings these changes in line 
with the new scheme.

This fixes a supplicant crash, so I would like to get some version of
it into hostap-1.0.

Also, I forgot the following: (oops!) :)

Intended-for: hostap-1

Thanks,
Angie


More information about the HostAP mailing list