[PATCH] dbus: Making the peer's properties accessible separately

Chinchilla, Angie V angie.v.chinchilla at intel.com
Fri Feb 3 19:02:15 EST 2012


On Fri, 2012-02-03 at 14:01 -0800, Chatre, Reinette wrote:
> Hi Jouni and Flávio,
> 
> On Fri, 2012-02-03 at 23:13 +0200, Jouni Malinen wrote:
> > On Fri, Feb 03, 2012 at 06:52:18PM -0200, Flávio Ceolin wrote:
> > > How there is the method org.freedesktop.DBus.Properties.GetAll
> > > that returns all properties from a specific interface, makes more
> > > sense separate the properties to be possible to get only a specific
> > > property using the method org.freedesktop.DBus.Properties.Get.
> >
> > While this may be a good change from the design view point, I'm a bit
> > worried about changing this interface if it breaks existing
> applications
> > that use the interface. The P2P extensions are relatively recent, so
> > this could still be acceptable, but I'm not going to apply this in
> the
> > current form until I hear an ack or two from people who are using
> this
> > interface.
> 
> We are using this interface and can support this change. Since this is
> an API change, could you please support this going to hostap-1? I take
> the liberty to add that new tag below.
> 
> Acked-by: Reinette Chatre <reinette.chatre at intel.com>
> intended-for: hostap-1
> 
> Flávio: I am just curious ... are you planning a similar change to the
> P2PDeviceProperties on the P2PDevice interface?

It would be great if we could get the P2P DBus interface cleaned up before releasing hostap-1.0. Obviously the interface becomes harder to tweak once we release. I'm all for taking these changes late, if others agree.

-Angie



More information about the HostAP mailing list