[PATCH 2/3] P2P: always re-select oper channel if not hard coded
arik at wizery.com
Thu Dec 27 03:51:45 EST 2012
On Thu, Dec 27, 2012 at 8:41 AM, Jouni Malinen <j at w1.fi> wrote:
> On Thu, Dec 27, 2012 at 07:32:58AM +0200, Jouni Malinen wrote:
>> On Tue, Dec 25, 2012 at 09:49:52PM +0200, Arik Nemtsov wrote:
>> > I'm attaching a new version of this patch, which includes the fix to
>> > p2p_process_go_neg_resp() I mentioned. It is rebased on the (close to)
>> > latest code.
>> This seems to break frequency specification as a p2p_connect parameter.
>> That case must not allow the p2p_reselect_channel() mechanisms to change
>> the forced channel. In addition, the debug log entry in the beginning of
>> p2p_reselect_channel() is quite confusing if the function gets called
>> with the new reason since the peer did not really reject the selected
>> channel in that case.
> It looks like the key missing part was the use of P2P_DEV_FORCE_FREQ
> flag which was already missing before this patch. I fixed and cleaned up
> the previous implementation and then applied a rebased version of this
> patch 2/3 with a somewhat more accurate commit log (and with the
> wpa_msg() call moved to the caller to avoid confusing debug log
The patch looks good. Thanks.
More information about the HostAP