[PATCH v2 0/4] Series short description

Jouni Malinen j at w1.fi
Fri Aug 10 07:13:41 EDT 2012


On Thu, Aug 09, 2012 at 11:54:56AM +0200, Michael Braun wrote:
> These patches make hostapd use the netlink api to create and remove vlan
> interfaces instead of the old kernel api.
> This removes the dependency from the system global linux vlan interface name
> type. It thus avoids conflicts with other applications, that can result in
> a non-usable network configuration, as the new vlan interfaces won't be added
> into the brige (due to the expected name being different from the actual name).

Thanks, applied with changes described below.

This seems to depend on libnl 3.1 or newer which is somewhat of an
unfortunate dependency to add since it breaks hostapd builds on most
existing platforms.. I added this as an optional build parameter instead
of replacement of the ioctl-based calls.

If the global parameter is fine (and why wouldn't it be?), it looks like
the ioctl-based interface can still be used with this in
full_dynamic_vlan_init():

-	vlan_set_name_type(VLAN_NAME_TYPE_PLUS_VID_NO_PAD);
+	vlan_set_name_type(hapd->conf->ssid.vlan_naming ==
+			   DYNAMIC_VLAN_NAMING_WITH_DEVICE ?
+			   VLAN_NAME_TYPE_RAW_PLUS_VID_NO_PAD :
+			   VLAN_NAME_TYPE_PLUS_VID_NO_PAD);


If that is not enough, adding CONFIG_VLAN_NETLINK=y into hostapd/.config
will replace the kernel API to netlink (with the cost of having to have
a suitable libnl version available).

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list