[PATCH 2/4] use netlink to create vlan interface

Jouni Malinen j at w1.fi
Sat Aug 4 14:05:04 EDT 2012


On Sat, Jul 07, 2012 at 10:52:12AM +0200, Michael Braun wrote:
> This permits hostapd to set the name of the created interface.

One question about the copyright and license statements in the new files
that needs to be addressed before I can apply these:

> diff --git a/src/ap/vlan_util.c b/src/ap/vlan_util.c
> new file mode 100644
> index 0000000..ca18963
> --- /dev/null
> +++ b/src/ap/vlan_util.c
> @@ -0,0 +1,137 @@
> +/*
> + * hostapd / VLAN initialization
> + * Copyright 2003, Instant802 Networks, Inc.
> + * Copyright 2005-2006, Devicescape Software, Inc.
> + * Copyright (c) 2009, Jouni Malinen <j at w1.fi>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * Alternatively, this software may be distributed under the terms of BSD
> + * license.
> + *
> + * See README and COPYING for more details.
> + */


This copyright notice and license statement do not look correct. Isn't
this (and same for vlan_util.h) new code? If so, there is not much point
in copying the copyright statements from vlan_init.c. In addition, any
new files needs to use the BSD license language (i.e., drop the GPLv2
alternative):

 * This software may be distributed under the terms of the BSD license.
 * See README for more details.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list