[PATCH 1/2] p2p: disable 11b rates only on p2p interface creation

Rajkumar Manoharan rmanohar at qca.qualcomm.com
Wed Sep 21 04:25:29 EDT 2011


On Wed, Sep 21, 2011 at 08:26:51AM +0300, Guy Eilam wrote:
> Hi,
> You have a small bug in your patch.
> 
> On Sat, Sep 3, 2011 at 7:51 PM, Rajkumar Manoharan
> <rmanohar at qca.qualcomm.com> wrote:
> > 11b rates are disabled blindly during p2p init based on driver
> > capability. This prevents use of CCK rates where p2p is not in
> > use. This patch disables 11b rates during the p2p interface
> > setup and also removes the disable_11b from global.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar at qca.qualcomm.com>
> > ---
[...]
> >
> >        ret = send_and_recv_msgs(drv, msg, NULL, NULL);
> > -       if (!ret)
> > +       if (!ret &&
> > +           (mode == NL80211_IFTYPE_P2P_CLIENT ||
> > +            mode == NL80211_IFTYPE_P2P_GO))
> > +               nl80211_disable_11b_rates(drv, ifindex, 1);
> >                return 0;
> 
> You are missing { } for the nl80211_disable_11b_rates() and return commands.
> 
Thanks for the review but this patch was dropped and 11b rates should not
be handled by this patch. Please refer Jouni's comments

http://lists.shmoo.com/pipermail/hostap/2011-September/023896.html

--
Rajkumar


More information about the HostAP mailing list