[PATCH] Remove references to time_t/time()

Jouni Malinen j at w1.fi
Mon Sep 12 15:27:19 EDT 2011


On Mon, Sep 12, 2011 at 04:33:11PM +0200, Per Ekman wrote:
> I encountered some more calls to time().

Thanks, applied.

> Would you consider removing the
> <time.h> include from utils/includes.h? That would catch these
> calls. With a vanilla build only os_unix.c complains and perhaps it
> should include time.h directly.

There are couple of other files that need time.h for functions that do
not have os_*() wrappers. Anyway, those can include time.h directly, so
yes, I did remove time.h from includes.h. It should be noted that
sys/time.h is also getting included there, but that had some more ifdef
processing around it, so I did not want to move that to os_unix.c.

> As an aside, trunk does not seem to build without WPS enabled
> because drv_callbacks.c:hostapd_notif_assoc() calls wps_is_20()
> which is not compiled when WPS is disabled.

Thanks! Fixed.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list