[RFC 02/14] [PATCH 02/14] driver_nl80211: use non-receiving socket for eapol TX

Jouni Malinen j at w1.fi
Fri Oct 21 17:11:43 EDT 2011


On Fri, Oct 21, 2011 at 09:20:03AM -0700, Ben Greear wrote:
> When adding new wpa_printf(MSG_DEBUG calls (or moving them around), please consider
> using wpa_dbg(drv->ctx, MSG_DEBUG instead.  If you don't have a valid context,
> you can pass in null for the first argument to wpa_dbg.

wpa_dbg(NULL, ...) and wpa_msg(NULL, ..) do not make any sense and
should I notice them, I will convert them to wpa_printf before
committing the patch..

> Anything not debug level could be wpa_msg(drv->ctx, MSG_ERROR, ....)

If you want to make it way more difficult to get the patch through.. ;-)
Any wpa_msg with MSG_INFO or higher priority will need to be carefully
considered since it can cause problems if used with a single ctrl_iface
that is attached to run commands.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list