[PATCH 2/6] nl80211: Convert some wpa_printf to wpa_msg methods.

Jouni Malinen j at w1.fi
Thu Oct 20 19:28:22 EDT 2011


On Thu, Oct 20, 2011 at 03:07:33PM -0700, Ben Greear wrote:
> Something like this?  (But, many more conversions of course):
> @@ -457,10 +457,10 @@ static void wpa_driver_nl80211_event_link(struct wpa_driver_nl80211_data *drv,
>          event.interface_status.ievent = del ? EVENT_INTERFACE_REMOVED :
>                  EVENT_INTERFACE_ADDED;
> 
> -       wpa_printf(MSG_DEBUG, "RTM_%sLINK, IFLA_IFNAME: Interface '%s' %s",
> -                  del ? "DEL" : "NEW",
> -                  event.interface_status.ifname,
> -                  del ? "removed" : "added");
> +       wpa_dbg(drv->ctx, MSG_DEBUG, "RTM_%sLINK, IFLA_IFNAME: Interface '%s' %s",
> +               del ? "DEL" : "NEW",
> +               event.interface_status.ifname,
> +               del ? "removed" : "added");

Yeah. Though, it may be easier to not try to get these in until the
other series goes through.. It is likely to be easier to just run
through a macro to do such conversions at some point rather than trying
to post patches to do the conversions since there is pretty high risk of
hitting conflicts with something like this. Though, in some cases like
this particular example, I'm not sure whether it really makes much sense
to do the conversion if the interface name is mentioned in the message
anyway.
 
-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list