[PATCH] To address SELECT_NETWORK command for an already associated Network

Jouni Malinen j at w1.fi
Sat Oct 1 13:52:51 EDT 2011


On Fri, Sep 30, 2011 at 02:30:34AM -0700, Jithu Jance wrote:
> For STA mode, SELECT_NETWORK doesn't address the scenario of an already associated network. If a selected network and currently associated network is same, wpa_supplicant currently keeps on "trying to associate" with the already associated network. In my opinion, either it should disassociate and then reconnect or shouldn't try to reconnect at all. The below patch will avoid reconnection, if it is already associated to the same network. Kindly review the patch and share your opinion.

I would be fine with avoiding the reconnection. However, this patch
changes the behavior in a way that may be unexpected, i.e., it does not
mark other networks disabled if the device happens to be connected with
the selected network. I don't think that this part should be made
conditional (i.e., the return on ssid && wpa_s->current_ssid == ssid
should be after the for loop).

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list