[PATCH] P2P return a successful response for p2p presence request if driver has return noa_len greater than 0

Jouni Malinen j at w1.fi
Mon Nov 21 09:06:32 EST 2011


On Sun, Nov 20, 2011 at 10:41:45PM -0800, Neeraj Kumar Garg wrote:
> Thanks for your comments. I agree that this area needs a lot of work but I think it is safe to return P2P_SC_SUCCESS if curr_noa_len > 0.

Not really.

> May I ask what is the purpose of returning P2P_SC_FAIL_UNABLE_TO_ACCOMMODATE if driver returned noa_len > 0?

The goal of the current implementation was to get minimal implementation
to pass mandatory certification requirements with a driver (not
nl80211-based). In other words, wpa_supplicant was accepting any request
if NoA was not used at the GO and rejecting any request if NoA was used.
As pointed out in this thread, more complete support needs quite a bit
more work and needs to include with architecture design for NoA
management in general.

In other words, I cannot apply this patch, but I would be fine with a
small patch to make this minimal design "work" with nl80211, i.e., make
sure we do not accept any request incorrectly if the device happens to
be using NoA internally without letting mac80211/wpa_supplicant know.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list