[PATCH 0/6] implement EAP SM param required functionality for the D-Bus interface

[Dan Williams]

On Wed, 2011-11-02 at 10:05 +0100, Johannes Berg wrote:
> On Wed, 2011-11-02 at 10:52 +0200, Jouni Malinen wrote:
> > On Wed, Nov 02, 2011 at 09:34:06AM +0100, Johannes Berg wrote:
> > > Hmm. This broke compilation when
> > 
> > Or well, my changes on top of that more likely.
> > 
> > > CONFIG_CTRL_IFACE_DBUS=y
> > > #CONFIG_CTRL_IFACE_DBUS_NEW=y
> > > 
> > > In file included from dbus/dbus_common.c:24:0:
> > > dbus/dbus_new.h:251:25: error: parameter 3 (‘rtype’) has incomplete type
> > > 
> > > 
> > > I tried fixing it with the right #include but ran into more include
> > > issues and gave up.
> > 
> > I was trying to avoid including some unnecessary header files with
> > trying to get the enum defined partiallyx.. Apparently that was fine for
> > a function prototype but not for the empty inline function that doesn't
> > use that parameter. Whatever.. I gave up and included common/defs.h to
> > fix the build issues.
> 
> Interesting. I thought I tried that, but ended up with errors on BIT().
> Since I can't reproduce it I guess I did something different :)

I tend to think that if a type is used in a file, then the header that
defines that type should be #included in that file.  Which is what I was
trying to do with the original patches at least.  Any other way seems
pretty magic and provides hard-to-debug build failures, and the files
should be protected from re-inclusion by #ifndef/#define/#endif anyway,
hopefully...

Dan