[RFC 34/40] WPS: add requested device type

Johannes Berg johannes at sipsolutions.net
Thu Mar 17 05:41:43 EDT 2011


On Thu, 2011-03-17 at 11:29 +0200, Jouni Malinen wrote:
> On Wed, Jan 05, 2011 at 08:53:30PM +0100, Johannes Berg wrote:
> > When the requested device type is set, add it
> > to the probe request WPS attributes.
> 
> > diff --git a/src/wps/wps.h b/src/wps/wps.h
> > @@ -90,6 +91,8 @@ struct wps_device_data {
> >  #define WPS_SEC_DEVICE_TYPES 5
> >  	u8 sec_dev_type[WPS_SEC_DEVICE_TYPES][WPS_DEV_TYPE_LEN];
> >  	u8 nb_sec_dev_types;
> > +	u8 req_dev_type[MAX_REQ_DEV_TYPE_COUNT][WPS_DEV_TYPE_LEN];
> > +	u8 nb_req_dev_types;
> >  	u32 os_version;
> >  	u8 rf_bands;
> 
> This does not make much sense to me... Requested Device Type is a
> parameter for scan commands. Why would it be stored as a device data?
> Shouldn't it be a parameter for scan/find commands instead?

Yes. Actually, it looks like externally (in DBus) it already is a
parameter for p2p_find, I'll look at changing this.

johannes



More information about the HostAP mailing list