[PATCH] hostapd: Don't force HT Mixed Mode for non-GF STAs

Jouni Malinen j at w1.fi
Wed Mar 16 05:56:28 EDT 2011


On Tue, Mar 15, 2011 at 04:41:34PM +0100, Helmut Schaa wrote:
> On Tue, Mar 15, 2011 at 4:27 PM, Jouni Malinen <j at w1.fi> wrote:
> > Or well, would
> > be even better, if the comment about the function were to be fixed to
> > match the implementation.
> 
> Could you elaborate please?

The function documentation has this to say about mixed mode:

Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
    (currently non-GF HT station is considered as non-HT STA also)

The second line of that is not the case anymore after your patch if I
understood it correctly.

> However, since we mask out the STA HT caps with our own HT
> caps during association every GF capable STA would appear as non-GF
> capable STA and as such would force the non-GF-STAs-present flag
> to be set.

OK, that seems to cover the case. I think it would be useful to review
all the flags at some point and document this type of special cases for
hostapd_ht_operation_update(). Anyway, I applied your patch (with the
now obsolete line removed from function documentation).

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list