[PATCH] wpa_supplicant: fix call to preauth candidate list generation

Dan Williams dcbw at redhat.com
Tue Jul 19 11:26:00 EDT 2011


On Mon, 2011-07-18 at 00:13 +0300, Guy Eilam wrote:
> Moved the call to the processing of the scan results for
> RSN pre-authentication candidates to an earlier position.
> This call was ignored most of the times due to a skip that
> is issues whenever the supplicant decides that there is no
> need to roam.

That would essentially revert part of:

commit 6d28fb9627155929012cda944aacd5a52ce7051a
Date:   Thu May 19 17:52:46 2011 +0300

    Fix regression in RSN pre-authentication candidate list generation
    
    Processing of the scan results for RSN pre-authentication candidates
    was moved to happen before the network was selected. This resulted in
    all candidates being dropped due to no SSID having been configured.
    Fix this by moving the processing to happen after the network has
    been selected. Since the raw scan results are not available at that
    point, use the BSS table instead of scan results to fetch the
    information.

no?

Dan

> Signed-off-by: Guy Eilam <guy at wizery.com>
> ---
>  wpa_supplicant/events.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> index e58abdc..df36548 100644
> --- a/wpa_supplicant/events.c
> +++ b/wpa_supplicant/events.c
> @@ -949,10 +949,10 @@ static int _wpa_supplicant_event_scan_results(struct wpa_supplicant *wpa_s,
>  		skip = !wpa_supplicant_need_to_roam(wpa_s, selected, ssid,
>  						    scan_res);
>  		wpa_scan_results_free(scan_res);
> +		wpa_supplicant_rsn_preauth_scan_results(wpa_s);
>  		if (skip)
>  			return 0;
>  		wpa_supplicant_connect(wpa_s, selected, ssid);
> -		wpa_supplicant_rsn_preauth_scan_results(wpa_s);
>  	} else {
>  		wpa_scan_results_free(scan_res);
>  		wpa_dbg(wpa_s, MSG_DEBUG, "No suitable network found");




More information about the HostAP mailing list