[PATCH] driver_nl80211: fix mode changes for P2P

Johannes Berg johannes at sipsolutions.net
Mon Jul 18 03:37:16 EDT 2011


On Sun, 2011-07-17 at 20:32 +0300, Jouni Malinen wrote:
> On Wed, Jun 22, 2011 at 05:14:15PM +0200, Johannes Berg wrote:
> > Recently something has been causing transitions
> > 	GO -> managed -> AP
> > mode on newly created P2P interfaces, and this
> > obviously breaks GO mode.
> 
> I'm not sure what could have changed this behavior recently.. The
> problem was in wpa_supplicant always forcing the interface to managed
> mode whenever initializing a new instance of the driver interface and
> that happens whenever using a separate P2P group netdev. The AP mode
> change after that has been there long time, too..
> 
> I removed the extra step to go to the station iftype when initializing
> driver_nl80211.c for an interface that was dynamically added (e.g., P2P
> group).
> 
> > As we discussed this shouldn't be happening,
> > but it's not clear to me that it won't happen
> > in the case where P2P doesn't use group iface.
> 
> The patches from Eliad address this mostly and they are more complete,
> so I applied them. There may still be some issues with the p2p parameter
> not set correctly in some cases, but those can be fixed separately.
> driver_nl80211.c should at least now address this consistently.
> 
> As such, I did not apply this patch with similar changes to
> wpa_driver_nl80211_set_mode() calls.

Sure, thanks, I hadn't been aware that Eliad's changes weren't in yet.
I'll give this a spin, might take me a while though (with vacation
coming up starting Saturday :-) )

johannes



More information about the HostAP mailing list