[PATCH] bsd: Use correct size for routing socket

Jouni Malinen j at w1.fi
Tue Feb 22 07:01:53 EST 2011


On Tue, Feb 22, 2011 at 08:39:57PM +0900, Masashi Honma wrote:
> The buffer size for routing socket is fixed to 2048.
> This patch fix it to obtain the size from OS.

Does this patch fix an issue that results in incorrect behavior? Are the
event messages really longer than 2048 bytes?

Wouldn't it be better to determine the buffer length once during
initialization and cache that information in struct bsd_driver_data to
avoid the extra sysctl calls? Or can this change dynamically during
wpa_supplicant/hostapd process runtime? Is the realloc() to smaller
buffer really of any help here? Isn't the buffer freed more or less
immediately?

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list