[PATCH 2/2] wext: Change wpa_printf to wpa_msg.

Ben Greear greearb at candelatech.com
Wed Feb 16 12:12:31 EST 2011


On 02/16/2011 08:40 AM, Jouni Malinen wrote:
> On Wed, Feb 16, 2011 at 08:35:25AM -0800, Ben Greear wrote:
>> What would be really nice is to use a base-class and not pass void*
>> all over the place!  This can be done easily enough, even in C.
>
> One problem with the driver wrapper interface is that it is supposed to
> be relatively stable and backwards compatible at source level. I do not
> want to do any large changes on it during 0.8.x branch anymore, so this
> type of changes would need to wait at least until the 0.8.x moves to its
> own branch at some point.

Seems to me that changing the void* is less trouble and risk
than adding a new ctx as you suggested in the previous mail.

But, either way it would be quite a bit of code churn,
and dealing with void* (and converting them to something
more specific) is prone to errors, so it would need to
be considered beta code until folks get to test it out
a bit.  We've been running with my patches for quite
a while and no obvious problems...but likely we are not
hitting all the code paths....

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



More information about the HostAP mailing list