[PATCH 1/2] Change wpa_printf to wpa_msg in scan.c

Ben Greear greearb at candelatech.com
Thu Feb 10 13:39:00 EST 2011


On 02/10/2011 10:27 AM, Jouni Malinen wrote:
> Thanks! I applied following patches:
>
> 0003-Change-wpa_printf-to-wpa_msg-in-scan.c.patch
> 0005-Convert-wpa_printf-to-wpa_msg-in-events.c.patch
> 0006-wpa-Convert-wpa_printf-to-wpa_msg.patch
> 0007-Convert-wpa_printf-to-wpa_msg-for-bss.c.patch
> 0018-supplicant-Convert-sme.c-to-use-wpa_msg-instead-of-w.patch
> 0019-supplicant-Convert-wpa_printf-to-wpa_msg-in-wpa_supp.patch
>
> I removed couple of changes that passed in NULL as the counter pointer
> since I see no point in using wpa_msg() instead of wpa_printf() in such
> cases. In addition, I introduced a new function (or well, pre-processor
> macro), wpa_dbg(), that can be used like wpa_msg(), but which can be
> compiled out from CONFIG_NO_STDOUT_DEBUG=y builds. This is needed to
> avoid noticeable increase in the binary size for builds that do not need
> verbose debugging.

Thanks!

One thing about passing null to wpa_msg:  Doesn't that
allow us to get messages over the cli interface tool, where
wpa_printf does not?

It seemed to me that converting all wpa_printfs to wpa_msg
(or wpa_dbg) was going to be more flexible going forward.
We could do a check for NULL and instead of printing
"NULL:" is my patches did, it could just leave out the "NULL:",
or maybe make more informed decisions about passing to
the cli, log files, etc.

But, either way is fine with me.

Thanks,
Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



More information about the HostAP mailing list