[PATCH] P2P return a successful response for p2p presence request if driver has return noa_len greater than 0

Jouni Malinen j at w1.fi
Sun Dec 18 13:35:41 EST 2011


On Tue, Dec 13, 2011 at 08:31:38PM -0800, Neeraj Kumar Garg wrote:
> Good point of disconnection. I think we need to call handle_presence from supplicant if a presence request was earlier received from the client and client is disconnecting without clearing the presence request.

I'm assuming that the driver/firmware has to maintain a STA entry anyway
and one part of that entry should really be the latest presence request
from the STA if the driver claims to supports presence requests in some
meaningful way. As such, it should be trivial for the driver/firmware to
take care of this clearing automatically without any new call from
wpa_supplicant (i.e., just use the existing disconnection mechanism).

> As per the spec, a client can give up presence request (or clear its presence request) by sending another presence request with 0 NOA attributes.
> I also feel that adding NOA attribute in the driver/firmware automatically may be a good idea at the moment. Later we can think of notifying supplicant for changes in IEs in beacons and probe-responses.

I do not see why wpa_supplicant would need to do anything with NoA
updates for Beacon or Probe Response frames. If we handle the Presence
Request/Response frames in wpa_supplicant, the new (modified or
unmodified as it may be) NoA will need to be returned from
handle_presence, but other than that, I would expect NoA information to
live within driver/firmware.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list