[PATCH 3/4] hostapd: Convert some wpa_printf to wpa_msg/dbg

Ben Greear greearb at candelatech.com
Sat Dec 10 11:35:40 EST 2011


On 12/10/2011 06:30 AM, Jouni Malinen wrote:
> On Mon, Oct 24, 2011 at 12:09:38PM -0700, greearb at candelatech.com wrote:
>> This generates better log messages when running multiple
>> interfaces in one process.
>
> And unexpected crashes in wpa_supplicant AP mode..
>
>> diff --git a/src/ap/ieee802_1x.c b/src/ap/ieee802_1x.c
>> @@ -2092,8 +2092,8 @@ static void ieee802_1x_finished(struct hostapd_data *hapd,
>> +		wpa_dbg(hapd, MSG_DEBUG, "IEEE 802.1X: Force disconnection after "
>> +			"EAP-Failure");
>
> While hapd is the context pointer in case of hostapd, this code is also
> used in wpa_supplicant AP mode and any wpa_msg/dbg ctx pointer has to be
> hapd->msg_ctx to avoid use of incorrect data structures.
>
> I applied with those ctx pointers fixed.

Thanks for fixing that up.

Is there no way to make the compiler help out with this
in c?  Maybe we can pass something around other than void*
for these contexts?

Thanks,
Ben

>


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


More information about the HostAP mailing list