[PATCH/RFC] improve overlap detection and handling for P2P PBC

Jouni Malinen j at w1.fi
Sat Dec 10 06:36:44 EST 2011


On Sat, Dec 10, 2011 at 12:00:21PM +0100, Vitaly Wool wrote:
> MAC addresses are the same, and P2P device address is the same as well
> (though different from the MAC) and well, otherwise my patch wouldn't work.

Thanks. I've seen a much worse case of this with the same UUID values,
but different MAC addresses..

> FWIW, the patch just provides a symmetry, one can run "wps_pbc
> xx:xx:xx:xx:xx:xx" from wpa_cli which will result in skipping overlap
> detection, so why don't we do that for P2P?

There is a long history behind this, but yes, it sounds reasonable to
allow this. I don't exactly agree with this being an "improvement" of
overlap detection, but well, that is easy to change for the commit
message ;-). I have actually looked at working around the worse case in
the past and just had to gave up there. That's why I wanted to make sure
this is a smaller subset of the issue and something that can actually be
resolved without completely disabling overlap detection.

-- 
Jouni Malinen                                            PGP id EFC895FA


More information about the HostAP mailing list