[PATCH v3 03/15] driver_nl80211: move AP SME setup to mode change

Johannes Berg johannes at sipsolutions.net
Sun Dec 4 04:29:37 EST 2011


On Sat, 2011-12-03 at 19:50 +0200, Jouni Malinen wrote:
> On Sat, Nov 19, 2011 at 01:39:13PM +0100, Johannes Berg wrote:
> > diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> 
> > @@ -5964,33 +5997,22 @@ static int wpa_driver_nl80211_set_mode(struct i802_bss *bss,
> > -	if (!ret && is_p2p_interface(drv->nlmode)) {
> > -		nl80211_disable_11b_rates(drv, drv->ifindex, 1);
> > -		drv->disabled_11b_rates = 1;
> > -	} else if (!ret && drv->disabled_11b_rates) {
> > -		nl80211_disable_11b_rates(drv, drv->ifindex, 0);
> > -		drv->disabled_11b_rates = 0;
> > +		nl80211_teardown_ap(bss);
> >  	}
> 
> Hmm.. That removal of disable_11b_rates() does not look correct. Was
> this some kind of merge/rebasing issue? I dropped the part that removed
> 11b rate handling here. Please verify that the changes are correct.

Yeah, that looks fishy, thanks for catching it.

I notice you changed the 11b-disable behaviour completely afterwards, it
looks OK to me except it seems to now be missing when the driver doesn't
advertise WPA_DRIVER_FLAGS_P2P_CONCURRENT?

johannes



More information about the HostAP mailing list