[PATCH 1/2] hostap: set ht_capab from wiphy when in P2P GO mode

Arik Nemtsov arik at wizery.com
Sun Aug 7 15:09:05 EDT 2011


On Sun, Aug 7, 2011 at 10:26, Jouni Malinen <j at w1.fi> wrote:
> On Sun, Aug 07, 2011 at 09:00:00AM +0300, Arik Nemtsov wrote:
>> On Sat, Aug 6, 2011 at 22:15, Jouni Malinen <j at w1.fi> wrote:
>> > I'm not completely sure I would like to get all HT capabilities enabled
>> > in this way by default based on driver capabilities. Doesn't this leave
>> > things in inconsistent state (e.g., HT_CAP_INFO_SUPP_CHANNEL_WIDTH_SET
>> > set, but secondary_channel not)?
>>
>> Yes this specific setting seems problematic. I guess for now we can
>> just mask out this bit in the received ht_capab?
>
> I'm not sure that is the only problematic one and as such, I would much
> rather see an explicit set of features that get enabled by default if
> there is good justification for doing so rather than just enabling
> everything.

The features enabled are of course card/driver specific. I'm afraid
there's no "catch-all" set I can think of.

For instance, the features required for wl12xx cards are:
HT_CAP_INFO_GREEN_FIELD, HT_CAP_INFO_SHORT_GI20MHZ, HT_CAP_INFO_RX_STBC_1

Should I initially mask only those in, and others can gradually add to the mask?

Arik


More information about the HostAP mailing list